Only time will tell, because the details are so vague, but this is the area where Trump likley deserves credit, although it appears like the US is trying to ram a deal through before the new Mexican President takes office and now the US is beholding to Canada (Trump insulted Trudeau)
https://www.cnn.com/2018/08/27/politics/mexico-us-trade-deal/index.html
The United States and Mexico have reached a preliminary agreement resolving key bilateral trade issues, a source familiar with the negotiations confirms to CNN.
President Donald Trump is expected to address the developments at 11 a.m.
Negotiators worked all day Sunday and were expected to reconvene at the US Trade Representative's office in Washington on Monday morning.
The preliminary agreement between the two countries resolves a key stumbling block in resuming NAFTA negotiations between the United States, Mexico and Canada.